Skip to content

Conversation

@thibaultduponchelle
Copy link
Member

Change

  • Do not tell to push after build is broken (bump) but before

  • This set of changes does not require a perldelta entry.

Copy link
Contributor

@book book left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions between the place you move the "push commits" to and the place it used to be does contain some instructions to commit changes.

What happens to those commits? Shouldn't they be pushed too, at some point?

@thibaultduponchelle
Copy link
Member Author

thibaultduponchelle commented Sep 29, 2025

What happens to those commits? Shouldn't they be pushed too, at some point?

Yes, later

The "Bump the version number" says:

Do note that at this stage, porting tests will fail. They will continue to fail until you've updated Module::CoreList, as described below.

So we don't want to push right after the Bump (broken build!), but still the commit(s) should be pushed later as part of "Update Module::CoreList"

@thibaultduponchelle thibaultduponchelle merged commit 49e87c0 into Perl:blead Sep 30, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants