Skip to content

utf8.c: Silence C comparison of ints warnings #23791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2025
Merged

utf8.c: Silence C comparison of ints warnings #23791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion embed.fnc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6179,7 +6179,7 @@ RTi |int |does_utf8_overflow \
|NN const U8 *e
RTi |int |isFF_overlong |NN const U8 * const s \
|const STRLEN len
RTi |int |is_utf8_overlong \
RTi |SSize_t|is_utf8_overlong \
|NN const U8 * const s \
|const STRLEN len
RS |HV * |new_msg_hv |NN const char * const message \
Expand Down
2 changes: 1 addition & 1 deletion proto.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions utf8.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,7 @@ The new names accurately describe the situation in all cases.
=cut
*/

PERL_STATIC_INLINE int
PERL_STATIC_INLINE SSize_t
S_is_utf8_overlong(const U8 * const s, const STRLEN len)
{
/* Returns an int indicating whether or not the UTF-8 sequence from 's' to
Expand Down Expand Up @@ -649,7 +649,7 @@ S_does_utf8_overflow(const U8 * const s, const U8 * e)
overflows_if_not_overlong: ;

/* Here, the sequence overflows if not overlong. Check for that */
int is_overlong = is_utf8_overlong(s, len);
SSize_t is_overlong = is_utf8_overlong(s, len);
if (LIKELY(is_overlong == 0)) {
return OVERFLOWS;
}
Expand Down Expand Up @@ -2319,8 +2319,8 @@ Perl_utf8_to_uv_msgs_helper_(const U8 * const s0,
malformed_text,
byte_dump_string_(s0, curlen, 0),
byte_dump_string_(s0,
MIN(avail_len,
overlong_detect_length),
MIN((SSize_t) avail_len,
overlong_detect_length),
0));
}
else {
Expand Down
Loading