Perl_newSVobject - adjusted for the default values #23831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`newSV_type(SVt_PVOBJ)` does the following initialization: * `ObjectMAXFIELD(sv) = -1;` * `ObjectFIELDS(sv) = NULL;` This commit makes two changes to `Perl_newSVobject` reflecting that: 1. There's no need for `Perl_newSVobject` to set either of these fields if `fieldcount` is zero, so that line is coverted into a DEBUGGING assert()` and one added for `ObjectMAXFIELD(sv)` for completeness. 2. When `fieldcount` is non-zero, setting `ObjectMAXFIELD(sv)` prior to the `Newx()` is more likely to result in the compiler realising that it only needs to do one `ObjectMAXFIELD(sv)` STORE rather than two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newSV_type(SVt_PVOBJ)does the following initialization:ObjectMAXFIELD(sv) = -1;ObjectFIELDS(sv) = NULL;This commit makes two changes to
Perl_newSVobjectreflecting that:There's no need for
Perl_newSVobjectto set either of these fields iffieldcountis zero, so that line is coverted into a DEBUGGING assert()and one added forObjectMAXFIELD(sv)` for completeness.When
fieldcountis non-zero, settingObjectMAXFIELD(sv)prior to theNewx()is more likely to result in the compiler realising that it only needs to do oneObjectMAXFIELD(sv)STORE rather than two.