fakesdio.h, utf8.h : Use legal macro name #23845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khwilliamson
changed the title
It is undefined behavior in C for a symbol name to begin with an underscore followed by a capital letter. It's a simple matter to move the underscore to the end
It is undefined behavior in C for a symbol name to begin with an underscore followed by a second underscore. It is a simple matter to change the name to have a single trailing underscore.
khwilliamson
force-pushed
the
rm_leading
branch
from
7b72f1d to
aa69fe4
Compare
tonycoz
approved these changes
Oct 13, 2025
Contributor
|
Thank you very much for this change. I'm not sure that it's best described as undefined behaivour, but rather is non-conforming code because it is using section 7.1.3 Reserved identifiers ; regardless, very glad to see this change. Also, Now that you point this out, we should look at typedefs that end in |
Contributor
Author
|
I don't know what the problem is with elements ending in |
Contributor
|
POSIX reserves names ending in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is undefined behavior in C for a symbol name to begin with an
underscore followed by a capital letter or a second underscore. It's a simple matter to move
the underscore to the end