Partially revert fd88a92 - it's GvCVGEN(gv), not CvGEN(cv) #23857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit partially reverts Perl@fd88a92 In two places in that commit, setting `GvCVGEN` to zero was changed to just asserting that the value was already zero, because the CV had just been created (with a Zeroed body). However, the value is set on a pre-existing GV, not on the fresh CV, so no assumptions should be made about the current value of `GvCVGEN`.
iabyn
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit partially reverts fd88a92
In two places in that commit, setting
GvCVGENto zero was changed to just asserting that the value was already zero, because the CV had just been created (with a Zeroed body). However, the value is set on a pre-existing GV, not on the fresh CV, so no assumptions should be made about the current value ofGvCVGEN.Closes #23855
Closes #23856