Skip to content

makedef.pl: Eliminate need for embed.fnc sync #23858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 22, 2025
Merged

makedef.pl: Eliminate need for embed.fnc sync #23858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
546bc0c
regen/embed.pl: Fix typos in comment
khwilliamson Oct 21, 2025
83a920b
regen/embed.pl: Add checks that O flag used correctly
khwilliamson Oct 21, 2025
ad7505e
regen/embed.pl: Avoid use of hard-coded list
khwilliamson Oct 21, 2025
96d55ae
makedef.pl: Use a name for $_
khwilliamson Oct 18, 2025
e44096d
makedef.pl: Refactor $variable initialization
khwilliamson Oct 18, 2025
6514e1b
makedef.pl: Remove nonsensical comment
khwilliamson Oct 18, 2025
a7b267d
embed.fnc: mv definition of more_sv
khwilliamson Oct 18, 2025
701558c
Add some duplication to makedef.pl from perl.h
khwilliamson Oct 19, 2025
08c55b5
makedef.pl: Eliminate need for embed.fnc sync
khwilliamson Oct 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions embed.fnc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,9 +620,11 @@
:
: 'O' Has a perl_ compatibility macro.
:
: The really OLD name for API funcs.
: The really OLD name for API funcs. These now also require the 'p'
: flag so as to generate a modern name. Obviously no new entries
: should get this flag.
:
: autodoc.pl adds a note that the perl_ form of this function is
: autodoc.pl adds a note that the 'perl_' form of this function is
: deprecated.
:
: 'o' Has no Perl_foo or S_foo compatibility macro:
Expand Down Expand Up @@ -2148,6 +2150,7 @@ p |int |mode_from_discipline \

: Used in sv.c and hv.c
Cop |void * |more_bodies |const svtype sv_type
Cp |SV * |more_sv
Cp |const char *|moreswitches \
|NN const char *s
Adp |void |mortal_destructor_sv \
Expand Down Expand Up @@ -6034,7 +6037,6 @@ S |void |glob_assign_glob \
|NN SV * const ssv \
|const int dtype
S |bool |glob_2number |NN GV * const gv
Cp |SV * |more_sv
S |void |not_a_number |NN SV * const sv
S |void |not_incrementable \
|NN SV * const sv
Expand Down
136 changes: 66 additions & 70 deletions embed.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,25 +49,23 @@
# define sv_setptrref(rv,ptr) sv_setref_iv(rv,NULL,PTR2IV(ptr))
# if !defined(PERL_NOCOMPAT)

/* Compatibility for various misnamed functions. All functions
in the API that begin with "perl_" (not "Perl_") take an explicit
interpreter context pointer.
The following are not like that, but since they had a "perl_"
prefix in previous versions, we provide compatibility macros.
*/
# define perl_atexit(a,b) call_atexit(a,b)
# define perl_call_argv(a,b,c) call_argv(a,b,c)
# define perl_call_method(a,b) call_method(a,b)
# define perl_call_pv(a,b) call_pv(a,b)
# define perl_call_sv(a,b) call_sv(a,b)
# define perl_eval_pv(a,b) eval_pv(a,b)
# define perl_eval_sv(a,b) eval_sv(a,b)
# define perl_get_av(a,b) get_av(a,b)
# define perl_get_cv(a,b) get_cv(a,b)
# define perl_get_hv(a,b) get_hv(a,b)
# define perl_get_sv(a,b) get_sv(a,b)
# define perl_init_i18nl10n(a) init_i18nl10n(a)
# define perl_require_pv(a) require_pv(a)
/* Compatibility for this renamed function. */
# define perl_atexit(a,b) Perl_call_atexit(aTHX_ a,b)

/* Compatibility for these functions that had a 'perl_' prefix before
* 'Perl_' became the standard */
# define perl_call_argv(a,b,c) Perl_call_argv(aTHX_ a,b,c)
# define perl_call_method(a,b) Perl_call_method(aTHX_ a,b)
# define perl_call_pv(a,b) Perl_call_pv(aTHX_ a,b)
# define perl_call_sv(a,b) Perl_call_sv(aTHX_ a,b)
# define perl_eval_pv(a,b) Perl_eval_pv(aTHX_ a,b)
# define perl_eval_sv(a,b) Perl_eval_sv(aTHX_ a,b)
# define perl_get_av(a,b) Perl_get_av(aTHX_ a,b)
# define perl_get_cv(a,b) Perl_get_cv(aTHX_ a,b)
# define perl_get_hv(a,b) Perl_get_hv(aTHX_ a,b)
# define perl_get_sv(a,b) Perl_get_sv(aTHX_ a,b)
# define perl_init_i18nl10n(a) Perl_init_i18nl10n(aTHX_ a)
# define perl_require_pv(a) Perl_require_pv(aTHX_ a)

/* Before C99, macros could not wrap varargs functions. This
provides a set of compatibility functions that don't take an
Expand Down Expand Up @@ -377,6 +375,7 @@
# define mg_set(a) Perl_mg_set(aTHX_ a)
# define mg_size(a) Perl_mg_size(aTHX_ a)
# define mini_mktime Perl_mini_mktime
# define more_sv() Perl_more_sv(aTHX)
# define moreswitches(a) Perl_moreswitches(aTHX_ a)
# define mortal_destructor_sv(a,b) Perl_mortal_destructor_sv(aTHX_ a,b)
# define mortal_getenv Perl_mortal_getenv
Expand Down Expand Up @@ -1669,6 +1668,54 @@
# define save_pushptri32ptr(a,b,c,d) S_save_pushptri32ptr(aTHX_ a,b,c,d)
# define save_scalar_at(a,b) S_save_scalar_at(aTHX_ a,b)
# endif
# if defined(PERL_IN_SV_C)
# define F0convert S_F0convert
# define anonymise_cv_maybe(a,b) S_anonymise_cv_maybe(aTHX_ a,b)
# define assert_uft8_cache_coherent(a,b,c,d) S_assert_uft8_cache_coherent(aTHX_ a,b,c,d)
# define croak_sv_setsv_flags(a,b) S_croak_sv_setsv_flags(aTHX_ a,b)
# define curse(a,b) S_curse(aTHX_ a,b)
# define expect_number(a) S_expect_number(aTHX_ a)
# define find_array_subscript(a,b) S_find_array_subscript(aTHX_ a,b)
# define find_hash_subscript(a,b) S_find_hash_subscript(aTHX_ a,b)
# define find_uninit_var(a,b,c,d) S_find_uninit_var(aTHX_ a,b,c,d)
# define glob_2number(a) S_glob_2number(aTHX_ a)
# define glob_assign_glob(a,b,c) S_glob_assign_glob(aTHX_ a,b,c)
# define not_a_number(a) S_not_a_number(aTHX_ a)
# define not_incrementable(a) S_not_incrementable(aTHX_ a)
# define ptr_table_find S_ptr_table_find
# define sv_2iuv_common(a) S_sv_2iuv_common(aTHX_ a)
# define sv_add_arena(a,b,c) S_sv_add_arena(aTHX_ a,b,c)
# define sv_display(a,b,c) S_sv_display(aTHX_ a,b,c)
# define sv_pos_b2u_midway(a,b,c,d) S_sv_pos_b2u_midway(aTHX_ a,b,c,d)
# define sv_pos_u2b_cached(a,b,c,d,e,f,g) S_sv_pos_u2b_cached(aTHX_ a,b,c,d,e,f,g)
# define sv_pos_u2b_forwards S_sv_pos_u2b_forwards
# define sv_pos_u2b_midway S_sv_pos_u2b_midway
# define sv_unglob(a,b) S_sv_unglob(aTHX_ a,b)
# define utf8_mg_len_cache_update(a,b,c) S_utf8_mg_len_cache_update(aTHX_ a,b,c)
# define utf8_mg_pos_cache_update(a,b,c,d,e) S_utf8_mg_pos_cache_update(aTHX_ a,b,c,d,e)
# define visit(a,b,c) S_visit(aTHX_ a,b,c)
# if defined(DEBUGGING)
# define del_sv(a) S_del_sv(aTHX_ a)
# define sv_mark_arenas() Perl_sv_mark_arenas(aTHX)
# define sv_sweep_arenas() Perl_sv_sweep_arenas(aTHX)
# endif
# if !defined(NV_PRESERVES_UV)
# if defined(DEBUGGING)
# define sv_2iuv_non_preserve(a,b) S_sv_2iuv_non_preserve(aTHX_ a,b)
# else
# define sv_2iuv_non_preserve(a) S_sv_2iuv_non_preserve(aTHX_ a)
# endif
# endif
# if defined(PERL_DEBUG_READONLY_COW)
# define sv_buf_to_rw(a) S_sv_buf_to_rw(aTHX_ a)
# endif
# if defined(USE_ITHREADS)
# define sv_dup_common(a,b) S_sv_dup_common(aTHX_ a,b)
# define sv_dup_hvaux(a,b,c) S_sv_dup_hvaux(aTHX_ a,b,c)
# define sv_dup_inc_multiple(a,b,c,d) S_sv_dup_inc_multiple(aTHX_ a,b,c,d)
# define unreferenced_to_tmp_stack(a) S_unreferenced_to_tmp_stack(aTHX_ a)
# endif
# endif /* defined(PERL_IN_SV_C) */
# if defined(PERL_IN_TOKE_C)
# define ao(a) S_ao(aTHX_ a)
# define check_unary() S_check_unary(aTHX)
Expand Down Expand Up @@ -2121,57 +2168,6 @@
# define get_regclass_aux_data(a,b,c,d,e,f) Perl_get_regclass_aux_data(aTHX_ a,b,c,d,e,f)
# endif
# endif /* defined(PERL_IN_REGEX_ENGINE) */
# if defined(PERL_IN_SV_C)
# define more_sv() Perl_more_sv(aTHX)
# if defined(PERL_CORE)
# define F0convert S_F0convert
# define anonymise_cv_maybe(a,b) S_anonymise_cv_maybe(aTHX_ a,b)
# define assert_uft8_cache_coherent(a,b,c,d) S_assert_uft8_cache_coherent(aTHX_ a,b,c,d)
# define croak_sv_setsv_flags(a,b) S_croak_sv_setsv_flags(aTHX_ a,b)
# define curse(a,b) S_curse(aTHX_ a,b)
# define expect_number(a) S_expect_number(aTHX_ a)
# define find_array_subscript(a,b) S_find_array_subscript(aTHX_ a,b)
# define find_hash_subscript(a,b) S_find_hash_subscript(aTHX_ a,b)
# define find_uninit_var(a,b,c,d) S_find_uninit_var(aTHX_ a,b,c,d)
# define glob_2number(a) S_glob_2number(aTHX_ a)
# define glob_assign_glob(a,b,c) S_glob_assign_glob(aTHX_ a,b,c)
# define not_a_number(a) S_not_a_number(aTHX_ a)
# define not_incrementable(a) S_not_incrementable(aTHX_ a)
# define ptr_table_find S_ptr_table_find
# define sv_2iuv_common(a) S_sv_2iuv_common(aTHX_ a)
# define sv_add_arena(a,b,c) S_sv_add_arena(aTHX_ a,b,c)
# define sv_display(a,b,c) S_sv_display(aTHX_ a,b,c)
# define sv_pos_b2u_midway(a,b,c,d) S_sv_pos_b2u_midway(aTHX_ a,b,c,d)
# define sv_pos_u2b_cached(a,b,c,d,e,f,g) S_sv_pos_u2b_cached(aTHX_ a,b,c,d,e,f,g)
# define sv_pos_u2b_forwards S_sv_pos_u2b_forwards
# define sv_pos_u2b_midway S_sv_pos_u2b_midway
# define sv_unglob(a,b) S_sv_unglob(aTHX_ a,b)
# define utf8_mg_len_cache_update(a,b,c) S_utf8_mg_len_cache_update(aTHX_ a,b,c)
# define utf8_mg_pos_cache_update(a,b,c,d,e) S_utf8_mg_pos_cache_update(aTHX_ a,b,c,d,e)
# define visit(a,b,c) S_visit(aTHX_ a,b,c)
# if defined(DEBUGGING)
# define del_sv(a) S_del_sv(aTHX_ a)
# define sv_mark_arenas() Perl_sv_mark_arenas(aTHX)
# define sv_sweep_arenas() Perl_sv_sweep_arenas(aTHX)
# endif
# if !defined(NV_PRESERVES_UV)
# if defined(DEBUGGING)
# define sv_2iuv_non_preserve(a,b) S_sv_2iuv_non_preserve(aTHX_ a,b)
# else
# define sv_2iuv_non_preserve(a) S_sv_2iuv_non_preserve(aTHX_ a)
# endif
# endif
# if defined(PERL_DEBUG_READONLY_COW)
# define sv_buf_to_rw(a) S_sv_buf_to_rw(aTHX_ a)
# endif
# if defined(USE_ITHREADS)
# define sv_dup_common(a,b) S_sv_dup_common(aTHX_ a,b)
# define sv_dup_hvaux(a,b,c) S_sv_dup_hvaux(aTHX_ a,b,c)
# define sv_dup_inc_multiple(a,b,c,d) S_sv_dup_inc_multiple(aTHX_ a,b,c,d)
# define unreferenced_to_tmp_stack(a) S_unreferenced_to_tmp_stack(aTHX_ a)
# endif
# endif /* defined(PERL_CORE) */
# endif /* defined(PERL_IN_SV_C) */
# if defined(PERL_MEM_LOG)
# define mem_log_alloc Perl_mem_log_alloc
# define mem_log_del_sv Perl_mem_log_del_sv
Expand Down
Loading
Loading