Skip to content

embed.fnc/group_end: correct the patend pointer decorator #23983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonycoz merged 1 commit into from
Dec 4, 2025
+10 −3
Merged

embed.fnc/group_end: correct the patend pointer decorator #23983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion embed.fnc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5306,7 +5306,7 @@ ST |char |first_symbol |NN const char *pat \
RS |const char *|get_num |NN const char *patptr \
|NN SSize_t *lenptr
S |const char *|group_end |SPTR const char *patptr \
|EPTR const char *patend \
|EPTRQ const char *patend \
|char ender
RS |SV * |is_an_int |NN const char *s \
|STRLEN l
Expand Down
2 changes: 1 addition & 1 deletion proto.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion t/op/pack.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ BEGIN {
set_up_inc(qw '../lib ../cpan/Math-BigInt/lib');
}

plan tests => 14724;
plan tests => 14726;

use strict;
use warnings qw(FATAL all);
Expand Down Expand Up @@ -2066,3 +2066,10 @@ SKIP:
like("$@", qr{Mismatched brackets in template},
"should match brackets correctly even without recursion");
}

{ # see discussion in #23980
ok !eval { my $x = pack "C["; 1 },
"pack throws with no closing ]";
like $@, qr/No group ending character '\]' found in template/,
"check the message";
}
Loading