Close padding hole in op_multiparam_named_aux struct#24174
Open
richardleach wants to merge 1 commit intoPerl:bleadfrom
Open
Close padding hole in op_multiparam_named_aux struct#24174richardleach wants to merge 1 commit intoPerl:bleadfrom
richardleach wants to merge 1 commit intoPerl:bleadfrom
Conversation
The _pahole_ tool, on AMD64, shows that this commit converts:
```
struct op_multiparam_named_aux {
const char * namepv; /* 0 8 */
STRLEN namelen; /* 8 8 */
U32 namehash; /* 16 4 */
/* XXX 4 bytes hole, try to pack */
PADOFFSET padix; /* 24 8 */
_Bool is_required:1; /* 32: 0 1 */
/* size: 40, cachelines: 1, members: 5 */
/* sum members: 28, holes: 1, sum holes: 4 */
/* sum bitfield members: 1 bits (0 bytes) */
/* padding: 7 */
/* bit_padding: 7 bits */
/* last cacheline: 40 bytes */
};
```
to
```
struct op_multiparam_named_aux {
PADOFFSET padix; /* 0 8 */
const char * namepv; /* 8 8 */
STRLEN namelen; /* 16 8 */
U32 namehash; /* 24 4 */
_Bool is_required:1; /* 28: 0 1 */
/* size: 32, cachelines: 1, members: 5 */
/* padding: 3 */
/* bit_padding: 7 bits */
/* last cacheline: 32 bytes */
};
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pahole tool, on AMD64, shows that this commit converts:
to