Close padding hole in BuiltinFuncDescriptor#24175
Open
richardleach wants to merge 1 commit intoPerl:bleadfrom
Open
Close padding hole in BuiltinFuncDescriptor#24175richardleach wants to merge 1 commit intoPerl:bleadfrom
richardleach wants to merge 1 commit intoPerl:bleadfrom
Conversation
The pahole tool, on AMD64, shows that this commit converts:
```
struct BuiltinFuncDescriptor {
const char * name; /* 0 8 */
U16 since_ver; /* 8 2 */
/* XXX 6 bytes hole, try to pack */
XSUBADDR_t xsub; /* 16 8 */
OP * (*checker)(OP *, GV *, SV *); /* 24 8 */
IV ckval; /* 32 8 */
_Bool is_experimental; /* 40 1 */
/* size: 48, cachelines: 1, members: 6 */
/* sum members: 35, holes: 1, sum holes: 6 */
/* padding: 7 */
/* last cacheline: 48 bytes */
};
```
to
```
struct BuiltinFuncDescriptor {
const char * name; /* 0 8 */
U16 since_ver; /* 8 2 */
_Bool is_experimental; /* 10 1 */
/* XXX 5 bytes hole, try to pack */
XSUBADDR_t xsub; /* 16 8 */
OP * (*checker)(OP *, GV *, SV *); /* 24 8 */
IV ckval; /* 32 8 */
/* size: 40, cachelines: 1, members: 6 */
/* sum members: 35, holes: 1, sum holes: 5 */
/* last cacheline: 40 bytes */
};
```
JRaspass
reviewed
Feb 7, 2026
| { "floor", SHORTVER(5,39), false, &XS_builtin_func1_scalar, &ck_builtin_func1, OP_FLOOR }, | ||
| { "is_tainted", SHORTVER(5,39), false, &XS_builtin_func1_scalar, &ck_builtin_func1, OP_IS_TAINTED }, | ||
| { "trim", SHORTVER(5,39), false, &XS_builtin_trim, &ck_builtin_func1, 0 }, | ||
| { "stringify", NO_BUNDLE, true, &XS_builtin_func1_scalar, &ck_builtin_func1, OP_STRINGIFY }, |
Contributor
There was a problem hiding this comment.
Might be nice to add a space after the true, to line it all up, like is_bool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pahole tool, on AMD64, shows that this commit converts:
to