Close padding hole in Perl_OpDumpContext struct#24176
Open
richardleach wants to merge 1 commit intoPerl:bleadfrom
Open
Close padding hole in Perl_OpDumpContext struct#24176richardleach wants to merge 1 commit intoPerl:bleadfrom
richardleach wants to merge 1 commit intoPerl:bleadfrom
Conversation
The pahole tool, on AMD64, shows that this commit converts:
```
struct Perl_OpDumpContext {
I32 level; /* 0 4 */
/* XXX 4 bytes hole, try to pack */
UV bar; /* 8 8 */
PerlIO * file; /* 16 8 */
_Bool indent_needed; /* 24 1 */
/* size: 32, cachelines: 1, members: 4 */
/* sum members: 21, holes: 1, sum holes: 4 */
/* padding: 7 */
/* last cacheline: 32 bytes */
};
```
to
```
struct Perl_OpDumpContext {
PerlIO * file; /* 0 8 */
UV bar; /* 8 8 */
I32 level; /* 16 4 */
_Bool indent_needed; /* 20 1 */
/* size: 24, cachelines: 1, members: 4 */
/* padding: 3 */
/* last cacheline: 24 bytes */
};
```
Contributor
|
Fails for It seems in C++, the order of the named initialisers has to match the order of the fields in the definition. Which seems suuuuuper-annoying as surely the entire point of named initialisers is to remove that interdependence.. Grr. :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pahole tool, on AMD64, shows that this commit converts:
to