Open
Conversation
PERL_DONT_CREATE_GVSV has been the default for more than 20 years now (since bdf3085). There's no real reason to enable PERL_CREATE_GVSV and it's almost undocumented, perlapi mentions it once in passing. It doesn't seem that any code on CPAN checks for PERL_CREATE_GVSV or PERL_DONT_CREATE_GVSV.
xenu
force-pushed
the
xenu/remove_create_gvsv
branch
from
a93754b to
0c11533
Compare
Contributor
What's the best way for someone to confirm that? |
Contributor
|
I searched https://grep.metacpan.org for |
Member
Author
By grepping, for example using grep.cpanauthors.org. Keep in mind in queries like this, there always will be lots of results from the copies of PPPort, these are irrelevant. One way to avoid it is to limit the searches to XS files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PERL_DONT_CREATE_GVSVhas been the default for more than 20 years now (since bdf3085).There's no real reason to enable
PERL_CREATE_GVSVand it's almost undocumented, perlapi mentions it once in passing. It doesn't seem that any code on CPAN checks forPERL_CREATE_GVSVorPERL_DONT_CREATE_GVSV.This set of changes does not require a perldelta entry.