Skip to content

Don't create CPAN package files when generating new apps#1727

Merged
cromedome merged 2 commits intomainfrom
feature/no-package-files
Jun 13, 2025
Merged

Don't create CPAN package files when generating new apps#1727
cromedome merged 2 commits intomainfrom
feature/no-package-files

Conversation

@cromedome
Copy link
Contributor

This... is kinda fluff, I admit. Don't add files typically used to package applications for CPAN when generating a new app.

If you use a custom app skeleton, this could be mute. But if you're like a lot of people and use the default skeleton, this is one little bit of less work after the fact.

I considered making this the default but didn't want to change what is accepted default behavior.

Not many Dancer2 apps are made to be distributed on CPAN, so provide a
way to not generate those files in the base skeleton app.
@yanick
Copy link
Contributor

yanick commented Jun 11, 2025

*mute = moot ;-P

It's good fluff. I'm also not sure about making it the default behavior. In any way, this is a good first step. I approve!

@GeekRuthie GeekRuthie self-requested a review June 11, 2025 23:55
Copy link
Contributor

@GeekRuthie GeekRuthie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very good fluff. I'll use that feature a fair bit, I betcha.

@cromedome cromedome merged commit 81496d5 into main Jun 13, 2025
18 checks passed
cromedome added a commit that referenced this pull request Sep 15, 2025
    [ BUG FIXES ]
    * GH #1701: Split cookie values on & only (Yanick Champoux)

    [ ENHANCEMENTS ]
    * GH #530: Make data censoring configurable (Yanick Champoux, David
      Precious)
    * GH #850: Scaffold tutorial app; allow multiple apps to be scaffolded
      in core Dancer2 (Jason A. Crome)
    * GH #1512: Log hook entries as they are executed (Yanick Champoux)
    * GH #1615: Remove Dancer2::Template::Simple from Dancer2 core (Jason
      A. Crome)
    * PR #1637: New, extendable configuration system (Mikko Koivunalho)
    * GH #1723: Enable use of a different Template Toolkit base class
      (Andy Beverley)
    * PR #1727: Don't create CPAN package files when generating new apps
      (Jason A. Crome)
    * PR #1731: Retire Template::Tiny fork, use CPAN's (Jason A. Crome,
      Karen Etheridge, Damien Krotkine, Yanick Champoux)
    * PR #1736: Allow config system to bootstrap itself (Yanick Champoux)
    * GH #1737: Add on_hook_exception for errors during hook processing
      (Andy Beverley)
    * PR #1739: Add source to on_hook_exception (Andy Beverley)
    * PR #1742: Refactor CLI for future expansion (Jason A. Crome)

    [ DOCUMENTATION ]
    * GH #1342: Document skipping private methods in pod coverage tests
      (Jason A. Crome)
    * PR #1721: New Dancer2 docs, reorganization of all documentation;
      from TPRF grant (Jason A. Crome)
    * PR #1741: Cover items missed in earlier documentation branch (Jason
      A. Crome)

    [ DEPRECATED ]
    * None

    [ MISC ]
    * None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants