Conversation
Seems that ::Request was being overly zealous and was splitting the cookie value on `;` as well. This is not the same behavior as HTTP::XSCookie, which only split on `&`. Fix #1701
yanick
commented
Jun 12, 2025
| diag "If you want extra speed, install HTTP::XSCookies" | ||
| if !Dancer2::Core::Cookie::_USE_XS; | ||
|
|
||
| sub run_test { |
Contributor
Author
There was a problem hiding this comment.
Same tests as before, I just wrapped them in subtests for better output.
Contributor
|
Thanks @yanick! 👍 |
cromedome
reviewed
Jun 25, 2025
Contributor
cromedome
left a comment
cromedome
left a comment
There was a problem hiding this comment.
Still 👍 from me. Thanks for looking at the test failures.
Contributor
Author
|
It's obviously a 👍 from me too. So I say: merge it! |
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems that ::Request was being overly zealous and was splitting the cookie value on
;as well. This is not the same behavior as HTTP::XSCookie, which only split on&.Fix #1701