Use V2 requests to /registerRecord #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam-lloyd
force-pushed
the
per-10338_use_v2_requests
branch
from
56cc5ae to
2d3f787
Compare
cecilia-donnelly
approved these changes
Nov 13, 2025
Member
cecilia-donnelly
left a comment
cecilia-donnelly
left a comment
There was a problem hiding this comment.
Makes sense to me and I see the test run here.
permanent_upload/permanent.py
Outdated
| "s3url": s3_info["destinationUrl"], | ||
| } | ||
| created_record_vo = self._register_record(auth_token, request) | ||
| print(created_record_vo) |
Member
There was a problem hiding this comment.
Do you want to keep this print in here?
All /registerRecord calls should use V2 requests, because this is necessary for the endpoint to fire events.
liam-lloyd
force-pushed
the
per-10338_use_v2_requests
branch
from
2d3f787 to
92772a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All /registerRecord calls should use V2 requests, because this is necessary for the endpoint to fire events.