Per 10403 add edtf sorting trigger tests #622
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently our tests can see the dist/ folder, which causes a warning about multiple sources of mocks. This commit excludes that folder from the tests so we don't get that warning anymore.
Our convention in this repo is to write our database queries in separate SQL files so they can be linted and syntax highlighted as SQL. Currently, the PATCH /folder endpoint dynamically generates its SQL within the Typescript instead. This commit updates the endpoint to move its query to a .sql file instead.
We want to allow users to be more expressive with time metadata. To this
end, we've added a field to the folder table to store time data in the
US Library of Congress's Extended Date Time Format. This commit exposes
that field in the responses of all endpoints that return folders, and
makes it editable via the PATCH /folder/{id} endpoint.
It is our convention that resources should be pluralized in routes in this API. Some of the routes, however, were created before we settled on that convention. This commit adds a plural /folders route, while leaving the /folder route in place for backward compatibility.
Member
Author
|
Built atop #614 |
To support sorting based on EDTF time statements, we've added a database trigger that calculates the lower bound of EDTF statements when folder.displaytime (or record.originalfilecreationtime) is updated. This commit adds a suite of tests that verify that that lower bound calculation is happening correctly.
liam-lloyd
force-pushed
the
per-10403_add_edtf_sorting_trigger_tests
branch
from
44e0600 to
69bca40
Compare
Member
Author
|
Tests will fail until https://github.com/PermanentOrg/back-end/pull/833 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.