Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
- Coverage 43.79% 43.77% -0.03%
==========================================
Files 366 366
Lines 11215 11215
Branches 1841 1841
==========================================
- Hits 4912 4909 -3
- Misses 6138 6142 +4
+ Partials 165 164 -1 ☔ View full report in Codecov by Sentry. |
meisekimiu
left a comment
meisekimiu
left a comment
There was a problem hiding this comment.
Left some code style comments, though I'll preemptively approve this so that we can get the experience team looking at this.
| .image { | ||
| position: relative; | ||
| height: 100%; | ||
| background: url('../../../../assets/img/sign_in_image.png'); |
There was a problem hiding this comment.
Can you give this a bit of a clearer name like legacy_lab_sign_in_image.png? Just so it's easier to track and understand its purpose without opening the file.
| Legacy Lab, a free four-week course where you'll create a lasting | ||
| archive and learn through: | ||
| </p> | ||
| <ul class="list"> |
There was a problem hiding this comment.
In theory we don't need some of these classes, right? There's only one kind of list that will ever show up in .legacy-lab-container. I think some of these classes are fine (such as start-date which conveys more semantic meaning about what the text is doing) but the ul tag is always going to represent a list so I feel like representing that in the classname is a bit redundant. Same for list-item on the li tags.
|
@yeslikesolo and I met to go over some adjustments to this page that we wanted to make and I applied them to this branch! Note that we can now remove the |
meisekimiu
force-pushed
the
PER-10036-swap-out-sign-in-image
branch
from
472bdf8 to
fdf6ab5
Compare
yeslikesolo
left a comment
yeslikesolo
left a comment
There was a problem hiding this comment.
WOOT WOOT! Looks great
|
I'm going to rebase and merge this so that it can go out in a deployment this week, regardless of when the deployment happens. |
Swap the sign in and register image for a temporarly new one.
Update text formatting in the Legacy Lab promotion on the sign in/sign up screen. This includes reducing font sizes and converting them to `rem` units, adjusting margins, using standard bullet points, and color adjustments. Co-authored-by: Han Pham <han@permanent.org>
Update CSS and HTML for the auth screens to adjust how the background is displayed for the Legacy Lab promo. Change out the background image as well. This background uses a slicing technique to extend the vertical stripes of the image without repeating the legacy lab circle[1]. Also use classes to isolate legacy lab specific background changes from the defaults we want to use for normal images. That way, we can just remove the references to classes in HTML without having to revert the CSS back. [1]: https://en.wikipedia.org/wiki/9-slice_scaling Co-authored-by: Han Pham <han@permanent.org>
meisekimiu
force-pushed
the
PER-10036-swap-out-sign-in-image
branch
from
fdf6ab5 to
19aa0da
Compare
3 participants
No description provided.