Fix the Info Pane #898
Merged
Fix the Info Pane #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 47.77% 47.76% -0.01%
==========================================
Files 351 351
Lines 11292 11292
Branches 1889 1889
==========================================
- Hits 5395 5394 -1
- Misses 5703 5709 +6
+ Partials 194 189 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
slifty
force-pushed
the
noissue-fix-info
branch
3 times, most recently
from
66fb1fe to
9f67498
Compare
slifty
force-pushed
the
noissue-fix-info
branch
2 times, most recently
from
73c6f4d to
24f1bab
Compare
A recent change to our index.html seems to have exposed a latent bug related to a circular dependency definition in our tag editor component. NewRelic is being loaded in a new way, which apparently changed the order that Angular was loading dependencies such that this became exposed. This also updates our DataService mock in the relevant test to account for an attribute that was missing / incomplete in a way that didn't matter before because it wasn't actually being used.
slifty
force-pushed
the
noissue-fix-info
branch
from
24f1bab to
ce15770
Compare
cecilia-donnelly
approved these changes
Jan 16, 2026
Member
cecilia-donnelly
left a comment
cecilia-donnelly
left a comment
There was a problem hiding this comment.
Thanks for figuring this out! It looks like it's working now. 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that was causing the info pane to fail to load after a recent change to the way we loaded NewRelic (which, apparently, is unrelated to NewRelic itself)
An analysis of the situation, ala Claude:
Why NewRelic Exposed the Bug
The root cause was always a circular dependency between EditTagsComponent → DataService → (via EditService) → EditTagsComponent. This was a latent bug that existed before PR #887 but never manifested.
The Chain of Events
Before PR #887:
After PR #887:
// main.ts - BEFORE Angular imports
import { BrowserAgent } from '@newrelic/browser-agent/loaders/browser-agent';
import { AppModule } from './app/app.module'; // Angular loads after
Adding @newrelic/browser-agent as a static import at the top of main.ts caused the bundler to:
The new order happened to evaluate edit-tags.component.ts before data.service.ts was fully initialized, causing DataService to be undefined when Angular tried to process the providers array.
Why Removing NewRelic Didn't Fix It
Once the bundler configuration changed (new index.html, new main.ts structure), the module evaluation order was permanently altered. NewRelic was just the trigger - removing it didn't restore the old order.
The Actual Fix
Removing DataService from EditTagsComponent's component-level providers eliminated the need for DataService to be defined at module decoration time, breaking the circular dependency.