Skip to content

Comments

Run build during CI#911

Merged
slifty merged 1 commit intomainfrom
672-run-build-during-ci
Jan 28, 2026
Merged

Run build during CI#911
slifty merged 1 commit intomainfrom
672-run-build-during-ci

Conversation

@slifty
Copy link
Contributor

@slifty slifty commented Jan 28, 2026

This PR improves our CI to ensure that build + storybook both work before allowing merge. This should make it less likely that we accidentally cause a regression that breaks either build.

Resolves #672

This will ensure build succeeds (it does not upload any artifacts).
This should prevent issues where CI passes but the build step fails.

Issue #672 Add build to CI
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.86%. Comparing base (01d8dba) to head (deaf061).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
+ Coverage   47.82%   47.86%   +0.04%     
==========================================
  Files         351      351              
  Lines       11306    11306              
  Branches     1892     1892              
==========================================
+ Hits         5407     5412       +5     
+ Misses       5708     5702       -6     
- Partials      191      192       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@slifty slifty enabled auto-merge January 28, 2026 19:40
Copy link
Member

@cecilia-donnelly cecilia-donnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Definite improvement.

@slifty slifty merged commit 253d433 into main Jan 28, 2026
10 checks passed
@slifty slifty deleted the 672-run-build-during-ci branch January 28, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add build to CI

2 participants