Skip to content

Comments

Create account from restricted share link completes share#916

Merged
aasandei-vsp merged 1 commit intomainfrom
PER-10446-create-account-restricted-share
Feb 13, 2026
Merged

Create account from restricted share link completes share#916
aasandei-vsp merged 1 commit intomainfrom
PER-10446-create-account-restricted-share

Conversation

@aasandei-vsp
Copy link
Contributor

@aasandei-vsp aasandei-vsp commented Feb 4, 2026

When a user is accessing a restricted share link without an account, a create account modal will appear. After the user follows the whole onboarding flow, when he navigates to shares, he will see the accepted share.

ISSUE: PER-10446

STEPS TO TEST:

Restricted --> auto approve on

  1. From an existing account, create a restricted share link;
  2. View the share link from a browser window where you are not logged in;
  3. From the share preview, click on create account in the pop up modal;
  4. Complete the signup form, click on “create archive for me” in the first onboarding screen, and skip the questionnaires to reach the final onboarding screen where your new archive name is confirmed;
  5. After confirming your new archive, navigate to Shared Files Workspace;

EXPECTED: The shared folder is visible;

Restricted --> auto approve off

  1. From an existing account, create a restricted share link, make auto-approve off;
  2. View the share link from a browser window where you are not logged in;
  3. From the share preview, click on create account in the pop up modal;
  4. Complete the signup form, click on “create archive for me” in the first onboarding screen, and skip the questionnaires to reach the final onboarding screen where your new archive name is confirmed;
  5. After confirming your new archive, navigate to Shared Files Workspace;

EXPECTED: The shared folder is NOT visible;

  1. From the previous account, approve the share request;
  2. Refresh the browser window where the new account was created, in the Shared Files Workspace;

EXPECTED: The shared folder is visible;

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.26%. Comparing base (34e56c6) to head (8ea0c78).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #916      +/-   ##
==========================================
+ Coverage   48.10%   48.26%   +0.16%     
==========================================
  Files         350      350              
  Lines       11317    11320       +3     
  Branches     1890     1892       +2     
==========================================
+ Hits         5444     5464      +20     
+ Misses       5686     5667      -19     
- Partials      187      189       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@cecilia-donnelly cecilia-donnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works really well, thank you!

Copy link
Member

@omnignorant omnignorant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested both the auto-approve and request access flows. They both appear to be fully operational.

Though I did maybe find a bug in how we are handling cookies in the onboarding flow or something like that. I will post that as a separate issue.

When a user is accessing a restricted share link without an account,
a create account modal will appear. After the user follows the whole
onboarding flow, when he navigates to shares, he will see the accepted
share.

ISSUE: PER-10446
@aasandei-vsp aasandei-vsp force-pushed the PER-10446-create-account-restricted-share branch from dd69f15 to 8ea0c78 Compare February 13, 2026 11:37
@aasandei-vsp aasandei-vsp merged commit b3c9c11 into main Feb 13, 2026
10 checks passed
@aasandei-vsp aasandei-vsp deleted the PER-10446-create-account-restricted-share branch February 13, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants