Create account from restricted share link completes share#916
Merged
aasandei-vsp merged 1 commit intomainfrom Feb 13, 2026
Merged
Create account from restricted share link completes share#916aasandei-vsp merged 1 commit intomainfrom
aasandei-vsp merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #916 +/- ##
==========================================
+ Coverage 48.10% 48.26% +0.16%
==========================================
Files 350 350
Lines 11317 11320 +3
Branches 1890 1892 +2
==========================================
+ Hits 5444 5464 +20
+ Misses 5686 5667 -19
- Partials 187 189 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cecilia-donnelly
approved these changes
Feb 5, 2026
Member
cecilia-donnelly
left a comment
There was a problem hiding this comment.
This works really well, thank you!
omnignorant
approved these changes
Feb 10, 2026
Member
omnignorant
left a comment
There was a problem hiding this comment.
I tested both the auto-approve and request access flows. They both appear to be fully operational.
Though I did maybe find a bug in how we are handling cookies in the onboarding flow or something like that. I will post that as a separate issue.
When a user is accessing a restricted share link without an account, a create account modal will appear. After the user follows the whole onboarding flow, when he navigates to shares, he will see the accepted share. ISSUE: PER-10446
dd69f15 to
8ea0c78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user is accessing a restricted share link without an account, a create account modal will appear. After the user follows the whole onboarding flow, when he navigates to shares, he will see the accepted share.
ISSUE: PER-10446
STEPS TO TEST:
Restricted --> auto approve on
EXPECTED: The shared folder is visible;
Restricted --> auto approve off
EXPECTED: The shared folder is NOT visible;
EXPECTED: The shared folder is visible;