Clear onboarding storage upon completion

[slifty]

This PR fixes an issue where onboarding data could carry over between onboarding sessions.

Resolves #951

[Copilot]

Pull request overview

This PR addresses onboarding state leaking across account-creation sessions by clearing persisted onboarding values from sessionStorage so subsequent signups/onboarding runs start clean (resolving #951).

Changes:

• Clear onboarding-related sessionStorage keys during signup submission.
• Clear onboarding-related sessionStorage keys after archive creation flow completes.
• Add unit tests to verify the sessionStorage keys are cleared in both flows.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
src/app/onboarding/components/create-new-archive/create-new-archive.component.ts	Clears onboarding session storage after onSubmit() and includes onboardingScreen in the cleared keys.
src/app/onboarding/components/create-new-archive/create-new-archive.component.spec.ts	Adds a test ensuring onboarding sessionStorage keys are cleared after archive creation.
src/app/auth/components/signup/signup.component.ts	Clears onboarding sessionStorage keys at the start of signup submission.
src/app/auth/components/signup/signup.component.spec.ts	Adds a test ensuring onboarding sessionStorage keys are cleared when signup is submitted.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.59%. Comparing base (c5d8a43) to head (3108334).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
- Coverage   48.69%   48.59%   -0.11%     
==========================================
  Files         350      350              
  Lines       11339    11348       +9     
  Branches     1898     1899       +1     
==========================================
- Hits         5522     5514       -8     
- Misses       5627     5643      +16     
- Partials      190      191       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

QA Instructions

Summary

This PR resolves issue #951 by ensuring that onboarding session data is cleared after onboarding is completed or when a user logs out. This is achieved by using a new method clearSessionStorage in the OnboardingService to avoid onboarding state contamination between different user accounts. Updates were made to the OnboardingService, SignupComponent, and CreateNewArchiveComponent.

---

Test Environment Setup

1. Ensure the application is running in a development environment.
2. Ensure you can access the signup and onboarding workflows.

---

Test Scenarios

Signup Component Behavior

1. Onboarding state cleared after onSubmit in the signup form:

   • Navigate to the signup page.
   • Fill out and submit the signup form with valid details.
   • Expected Result: Verify that the clearOnboarding method of the OnboardingService is invoked during form submission.

2. Regression Test - Regular Signup functionality:

   • Ensure that a user is successfully created with valid signup details.
   • Expected Result: After signup, the user should be logged in and onboarded without any errors.

---

Onboarding Workflow Behavior

3. Session storage clears after successful archive creation:

   • Start a new user onboarding session.
   • Complete the onboarding process and submit an archive creation request.
   • Expected Result: Verify that onboarding session keys (e.g., archiveName, goals, reasons, etc.) are cleared from session storage when the archive is successfully created.

4. Session storage not cleared if archive creation fails:

   • Start a new user onboarding session.
   • Simulate a failure by configuring the API call to create an archive to return an error (e.g., network or server error).
   • Expected Result: Verify that onboarding session keys are NOT cleared from session storage.

5. Regression Test - Onboarding workflow:

   • Start and complete the entire onboarding workflow with various valid configurations (e.g., different archiveType and goals).
   • Expected Result: Verify onboarding proceeds to the end, creates the archive successfully, and clears the onboarding session data.

---

Regression Risks

1. Signup/Onboarding Critical Path:

   • Verify that changes to session data handling don't cause issues with the signup process or onboarding completion.

2. Session Storage Handling:

   • Check for unintended side effects when clearing session storage, e.g., other non-onboarding-related session data should remain intact.

---

Things to Watch For

1. Service Invocation in All Scenarios:

   • Ensure clearSessionStorage and resetSessionState methods are consistently triggered under their respective conditions.

2. Edge Cases & Errors:

   • Test scenarios where the onboarding workflow is interrupted (e.g., page refreshes, browser restarts) and verify correct session handling.

3. Multi-tab Scenarios:

   • Test onboarding and signup flows in multiple tabs to ensure no session conflicts.

---

Generated by QA Instructions Action