added --no-cache and better permissions for user #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added --no-cache option and changed the removed directory to only /tmp/ better permissions for tor user, the default one is enough to be safe changed CMD to ENTRYPOINT, it's just for standarization
Owner
|
@miracle091 thanks for your contribution, looks like the image build process is broken, needs your fixes applied. |
PeterDaveHello
requested changes
Jan 28, 2023
Owner
PeterDaveHello
left a comment
PeterDaveHello
left a comment
There was a problem hiding this comment.
Image built failed:
Step 6/10 : COPY --chown=tor torrc /etc/tor/
unable to convert uid/gid chown string to host mapping: can't find gid for group tor: no such group: tor
| EXPOSE 8853/udp 9150/tcp | ||
|
|
||
| CMD ["/usr/bin/tor", "-f", "/etc/tor/torrc"] | ||
| ENTRYPOINT ["/usr/bin/tor", "-f", "/etc/tor/torrc"] |
Owner
There was a problem hiding this comment.
Shouldn't be changed in this commit / pull request.
| rm -rf /var/cache/apk/* && \ | ||
| apk -v add --no-cache tor@edge obfs4proxy@edge curl && \ | ||
| chown -R tor /var/lib/tor/ && \ | ||
| rm -rf /tmp/* && \ |
Owner
There was a problem hiding this comment.
This change seems to be unrelated to the topic.
Owner
|
Hi @miracle091, Could you please let me know if you'd like to proceed with this pull request? Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added --no-cache option and changed the removed directory to only /tmp/ better permissions for tor user, the default one is enough to be safe changed CMD to ENTRYPOINT, it's just for standarization