Add 9 more URL shortener domains#127
Conversation
dosubot
bot
added
the
size:XS
📝 WalkthroughWalkthroughThis pull request adds nine new entries to the URL shortener domains list. The changes solely introduce additional domains without removing or modifying any existing entries. The updated list now includes the following domains: Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
PR Reviewer Guide 🔍(Review updated until commit a66b778)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
/review |
qodo-free-for-open-source-projects
bot
added
Review effort 1/5
and removed
Review effort [1-5]: 1
labels
|
Persistent review updated to latest commit b404cf0 |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
CI Review from Copilot
The failing job is due to a sorting issue in the
listfile. The error message indicates that the file is not properly sorted. To fix this, you need to ensure that the entries in thelistfile are sorted correctly.Here is the diff provided in the logs showing the necessary changes:
@@ -237,6 +237,7 @@ cbt.gg cc.cc cdl.booksy.com +centi.ai cfl.re chip.tl chl.li @@ -277,6 +278,7 @@ cnvrge.co cockroa.ch comca.st +come.ac conta.cc cookcenter.info coop.uk @@ -724,6 +726,7 @@ lmg.gg lmt.co lmy.de +ln.run lnk.bz lnk.direct lnk.do @@ -1102,6 +1105,12 @@ shorl.com short.gy shorten.asia +shorten.ee +shorten.is +shorten.so +shorten.tv +shorten.world +shorter.me shorturl.ae shorturl.asia shorturl.at @@ -1516,12 +1525,3 @@ zywv.us zzb.bz zzu.info -shorten.tv -shorten.so -shorten.world -centi.ai -ln.run -shorten.ee -shorten.is -shorter.me -come.acTo fix the issue, ensure the
listfile is updated with the correct sorting as shown in the diff above. Here is a snippet of the correctedlistentries:cbt.gg cc.cc cdl.booksy.com centi.ai cfl.re chip.tl chl.li ... shorten.asia shorten.ee shorten.is shorten.so shorten.tv shorten.world shorter.me ... zywv.us zzb.bz zzu.infoMake sure to update your
listfile accordingly and rerun the workflow to verify the fix.
Add 9 more URL shortener domains: shorten.tv shorten.so shorten.world centi.ai ln.run shorten.ee shorten.is shorter.me come.ac
PeterDaveHello
force-pushed
the
patch-1
branch
from
b404cf0 to
8df0109
Compare
|
Dear @PeterDaveHello, Is it good to be merged? Best Regards, |
|
Hi @megaworldai, Thanks for the contribution! The CI is failing because the domains need to be sorted alphabetically. Could you help fix the sorting? The CI output shows exactly where each domain should go, and your assistance would help get this merged much faster. Thanks! |
|
Dear @PeterDaveHello, I already fixed the sorting, could you help to check and merge? Thank you so much! |
|
/review |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Persistent review updated to latest commit a66b778 |
There was a problem hiding this comment.
Pull Request Overview
Add nine new URL shortener domains to the existing list to broaden supported services.
- Introduces
centi.ai,come.ac,ln.run,shorten.ee,shorten.is,shorten.so,shorten.tv,shorten.world, andshorter.me. - Ensures the main
listfile reflects these additions for URL detection logic.
Comments suppressed due to low confidence (1)
list:246
- Consider adding or updating unit tests to verify that URLs using these newly added domains (e.g., "centi.ai", "shorten.tv") are correctly recognized by the URL shortener detection logic.
centi.ai
|
I'll review and verify the results in a few days. Thanks for your patience. |
2 participants
User description
Pull Request Template
Description
Add 9 more URL shortener domains:
Domain Usage Proof
Checklist
Rationale
Explain why these domains should be added or removed: it is false positive on virustotal
Additional Notes
PR Type
Enhancement
Description
Added 9 new URL shortener domains to the list.
Expanded support for URL shortening services.
Changes walkthrough 📝
list
Added 9 new URL shortener domainslist
shorten.tv,shorten.so,shorten.world,centi.ai,ln.run,shorten.ee,shorten.is,shorter.me, andcome.ac.Summary by CodeRabbit
centi.ai,come.ac,ln.run,shorten.ee,shorten.is,shorten.so,shorten.tv,shorten.world, andshorter.me. This provides users with a more diversified set of domain choices for their URLs.