Skip to content

Commit afc66b2

Browse files
committed
fix #20
1 parent 69af20b commit afc66b2

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

grid-view-common.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@ See the License for the specific language governing permissions and
1414
limitations under the License.
1515
***************************************************************************** */
1616

17+
import { ObservableArray } from "data/observable-array";
1718
import { parse } from "ui/builder";
1819
import { CoercibleProperty, Length, PercentLength, Property, Template, View } from "ui/core/view";
20+
import { addWeakEventListener, removeWeakEventListener } from "ui/core/weak-event-listener";
1921
import { ItemsSource } from "ui/list-view";
2022
import { GridView as GridViewDefinition } from ".";
2123

@@ -85,6 +87,15 @@ export const itemsProperty = new Property<GridViewBase, any[] | ItemsSource>({
8587
const getItem = newValue && (newValue as ItemsSource).getItem;
8688

8789
target.isItemsSourceIn = typeof getItem === "function";
90+
91+
if (oldValue instanceof ObservableArray) {
92+
removeWeakEventListener(oldValue, ObservableArray.changeEvent, target.refresh, target);
93+
}
94+
95+
if (newValue instanceof ObservableArray) {
96+
addWeakEventListener(newValue, ObservableArray.changeEvent, target.refresh, target);
97+
}
98+
8899
target.refresh();
89100
}
90101
});

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nativescript-grid-view",
3-
"version": "3.0.1",
3+
"version": "3.0.2",
44
"description": "A NativeScript GridView widget.",
55
"main": "grid-view",
66
"typings": "grid-view.d.ts",

0 commit comments

Comments
 (0)