Conversation
|
Hm so yeah I'm not really in favor of turning on bundling due to the quarantine issue, the reason it was disabled initially is because it was confusing to users. I wouldn't necessarily be opposed to adding the bundled variant as an additional option though As far as the ShowInDock setting, does this only apply to the avalonia window icon or does it hide the terminal icon as well? And for the UseAppHost edit, what is the purpose of that? It's my understanding that it's automatically enabled (and required) for the self contained builds anyway I do appreciate the PR though and am always open to contributions, particularly for OSX since I don't have a Mac myself which makes testing stuff on there very difficult |
… in the menu bar.
|
Totally fair, I've removed the changes to bundling and UseAppHost (you're right, it was unnecessary!) I've gone through and hidden the system tray options as well, as they won't work if HideInDock is true, and I don't know if there's a way to change that once the app is running, so to prevent the app from getting lost. ShowInDock only applies to the app once it's running, the terminal window that boots it will persist unfortunately. |
This shouldn't be a concern as just running SFP again should bring back the window of the existing instance if one is already running, assuming that functionality works correctly on OSX
And with that said I'm not certain of the value of forcing this to be false then, as the terminal window icon seems to be the most annoying part. Should ShowInDock not just be added as an additional setting (even if defaulting to off)? |
This PR addresses the feedback #202
This was already implemented, but disabled due to macOS quarantining the unsigned app:
Apps can be manually unblocked by running
xattr -dr com.apple.quarantine SFP_UI.appin the terminal, but I'll leave it up to you if its worth trying to get users to run this or just stick with the executable approach. 🤷♀️It also might be worth investigating brew for handling macOS installation? I don't have any developer experience here, sorry!
Not exactly a fully implemented feature, but using the
MacOSPlatformOptionsin the AppBuilder can hide the app from the dock entirely. There is no way that I'm aware of to get the icon back when an Avalonia window is open unfortunately. 😢