Skip to content

phui backend #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

phui backend #9

wants to merge 14 commits into from

Conversation

darionco
Copy link
Contributor

No description provided.

Copy link
Member

@kerbearasaurus kerbearasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of minor nitpicks and questions. overarching question is if we're refactoring for pocketbase should we just bite the bullet and replace Strapi with PhenoBackendProvider or something for the specific implementation since it's with Pocketbase instead of Strapi now? I don't feel super strongly about it but since this is a refactor I figured it could be a good time....

@@ -32,7 +31,7 @@ class RenderLayoutState extends State<RenderLayout> {
@override
void initState() {
super.initState();
var dataProvider = StrapiDataProvider(sourceId: Strapi().server, category: widget.category);
var dataProvider = StrapiDataProvider(sourceId: Strapi().server, category: widget.tagId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nitpicky but if this isn't strapi anymore should we rename the dataprovider to a more generic naming convention?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the purpose of these webview changes exactly? webviews seemed to work on iOS and I thought (although maybe I am misremembering) they worked on macOS as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants