This repository was archived by the owner on Mar 31, 2025. It is now read-only.
[BUGFIX] Check if property exists in MarkdownExtra class#355
Open
iaian7 wants to merge 1 commit intoPhileCMS:developfrom
Open
[BUGFIX] Check if property exists in MarkdownExtra class#355iaian7 wants to merge 1 commit intoPhileCMS:developfrom
iaian7 wants to merge 1 commit intoPhileCMS:developfrom
Conversation
Member
|
Hi, thanks for the PR. I'm going to review in the New Year. - You all have a
happy New Year.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #354, fixing the dynamic property ErrorException in PHP 8.2
Changes proposed in this pull request:
Check for property validity before attempting to set custom configuration variables in the Markdown plugin. It's very possible this is not the ideal or correct method for solving the issue, and is offered as a quick fix for anyone running into the same issues I have when running PHP 8.2, until an official approach or correction is recommended.
@PhileCMS/Phile @Schlaefer please review this pull request