Add support for native platform bottles instead of only flatpak#454
Open
madalee-com wants to merge 1 commit intoPhilipK:feature/tauri-migrationfrom
Open
Add support for native platform bottles instead of only flatpak#454madalee-com wants to merge 1 commit intoPhilipK:feature/tauri-migrationfrom
madalee-com wants to merge 1 commit intoPhilipK:feature/tauri-migrationfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The existing implementation for Bottles only supports the Flatpak version of bottles. As is the case with many Flatpak's, bottles can be limited by Flatpak, and as such, some users prefer to run bottles native(such as through an aur install on arch).
This PR adds a new setting in the Bottles section:
"Use Flatpak version"
Implementation
All code changes were done in the bottles platform.rs and tested in both the legacy egui and new tauri ui.
Potential Issues
This changes the default behavior of the bottles implementation to assume "native" mode not "flatpak" mode.
You may want to change the code to default to "flatpak" mode for backward compatibility when users upgrade.
Related bugs that should be solved