Skip to content

Comments

Add support for native platform bottles instead of only flatpak#454

Open
madalee-com wants to merge 1 commit intoPhilipK:feature/tauri-migrationfrom
madalee-com:fix-bottles-native
Open

Add support for native platform bottles instead of only flatpak#454
madalee-com wants to merge 1 commit intoPhilipK:feature/tauri-migrationfrom
madalee-com:fix-bottles-native

Conversation

@madalee-com
Copy link

Purpose

The existing implementation for Bottles only supports the Flatpak version of bottles. As is the case with many Flatpak's, bottles can be limited by Flatpak, and as such, some users prefer to run bottles native(such as through an aur install on arch).

This PR adds a new setting in the Bottles section:

"Use Flatpak version"

  • When enabled, BoilR will search for bottles games using the Flatpak version of bottles-cli, and will make shortcuts in Steam using the Flatpack version of bottles-cli launcher. (This is the default behavior.)
  • When disabled, BoilR will us the native versions of bottles-cli to search for bottles, as well as in the Steam shortcuts.

Implementation

All code changes were done in the bottles platform.rs and tested in both the legacy egui and new tauri ui.

Potential Issues

This changes the default behavior of the bottles implementation to assume "native" mode not "flatpak" mode.
You may want to change the code to default to "flatpak" mode for backward compatibility when users upgrade.

Related bugs that should be solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant