Merged
Conversation
The Images tab would freeze when selecting shortcuts or correcting grid IDs because block_on() was called on the main UI thread. Changes: - Convert handle_shortcut_selected() to spawn async SteamGridDB search in the background instead of blocking the UI thread - Convert handle_correct_grid_request() to spawn async name search in the background instead of blocking - Add poll_grid_id_search() and poll_name_search() to receive async results via watch channels - Add grid_id_search and name_search fields to ImageSelectState - Fix Windows file:// URL paths by normalizing backslashes to forward slashes (file:/// prefix for absolute paths) - Remove blocking thread::sleep(100ms) after image selection, replace with request_repaint() Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
6 tasks
PhilipK
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
handle_shortcut_selected()from blockingblock_on()to async background task with watch channelhandle_correct_grid_request()from blockingblock_on()to async background taskpoll_grid_id_search()andpoll_name_search()to receive async results each framefile://URL paths by normalizing backslashes to forward slashesthread::sleep(100ms)after image selection, userequest_repaint()insteadProblem
The Images tab would freeze/hang when clicking on a shortcut because
block_on()was called on the main UI thread for SteamGridDB API requests. Similarly, the "correct grid ID" feature would block the UI during name searches.Test plan
🤖 Generated with Claude Code