Feature/credential provider service #3143
Conversation
…reateCredentialRequest
…etCredentialRequest
PhilippC
left a comment
PhilippC
left a comment
There was a problem hiding this comment.
Thanks for creating the PR! Unfortunately I wasn't able to test it successfully. Do I need to enable anything first because KP2A now pops up as credential prodvider service in the CredentialManagerSample?
| { | ||
| var username = entry.Strings.ReadSafe(PwDefs.UserNameField); | ||
| var password = entry.Strings.ReadSafe(PwDefs.PasswordField); | ||
| if (string.IsNullOrEmpty(username) || string.IsNullOrEmpty(password)) |
There was a problem hiding this comment.
why is this? Couldn't some credentials have empty username or password?
There was a problem hiding this comment.
Because PasswordCredential requires non-null, non-empty password,
Although, username could be empty but not null, I will remove the check for username.
I think you will need to enable the service in "Settings" > "Passwords, Passkeys and Accounts" |
2 participants
Initial implementation of credential provider service to store and return password credential.