Remove a lot of dead code, consolidate localization code, bump dependencies#135
Merged
PhilippvK merged 13 commits intoPhilippvK:masterfrom Apr 8, 2025
Merged
Remove a lot of dead code, consolidate localization code, bump dependencies#135PhilippvK merged 13 commits intoPhilippvK:masterfrom
PhilippvK merged 13 commits intoPhilippvK:masterfrom
Conversation
This is preferred to source and target as it checks for API availability as well as syntax validity. See https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html for more information.
AFAIK these diagrams are unused and can be removed to have less dependencies and speed up the build.
This is the conventional way of declaring dependencies in Maven projects . Now all dependency versions are in the root POM so subprojects always use the same versions of plugins and libraries.
No major changes. The only notable changes are that the group id for download-maven-plugin was changed and I fixed Mockito complaining about using a deprecated API for strictness.
Instead of including all Netty classes in the built jar, now only the packages that are actually used are included. This decreases the jar size from 6.5 MB to 4.1 MB. Also, Netty 4.2.0 deprecated NioEventLoopGroup and recommends creating a MultiThreadIoEventLoopGroup with the Nio handler transport factory instead.
There are no translations for different locales anyway so the code is simpler when it only deals with Languages instead of a mix of locales and languages.
Instead of strings
This revealed that RoundRadioButton is unused and could be removed.
The code for these classes has already been deobfuscated so the dead constructors can be removed.
Never called
PhilippvK
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following notable changes: