More deobfuscation, renaming, clean-up#136
Merged
PhilippvK merged 8 commits intoPhilippvK:masterfrom Oct 27, 2025
Merged
Conversation
All the GUI components support using colors so this prefix does not add any clarity and only makes class names longer.
MultiColumnSelectableList is a mouthful but it is necessary to distinguish the class from the SeletableGroupList.
This makes it clear what distinguishes the class from MultiColumnSelectableList, the GroupList can have entries grouped into categories and only supports two columns instead an arbitrary amount.
Instead of using int constants and doing special logic in MultiColumnSelectableList, the sort order function can be stored inside the enum.
PhilippvK
approved these changes
Oct 15, 2025
| @@ -196,9 +210,9 @@ public void actionPerformed(ActionEvent evt) { | |||
| .getSelectedIndex() /*+ (isUsingCustomServer ? ("\t" + this.choicerTrackCategory.getSelectedIndex()) : "")*/); | |||
| } else { | |||
| if (var2 == this.buttonStartChampionship) { | |||
Owner
There was a problem hiding this comment.
Why not deobfuscase var2, too?
I guess that would be eventSource or similar.
| return var1 == null ? null : (String) var1.getData(); | ||
| private TrackSet getSelectedTrackSet() { | ||
| MultiColumnListItem<TrackSet> var1 = this.trackSetList.getSelectedItem(); | ||
| return var1 == null ? null : var1.getData(); |
Previously, it was just holding Objects and relied on casting.
Only for choicer with 255 autotransformed into spinner, not used in practice
PhilippvK
approved these changes
Oct 27, 2025
Owner
|
Thanks @StenAL! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
Object