Improve stroke line control

[nuhakala]

Hello, this PR

• Changes the alternative game mode contor (drawing dashed line) from meta key to mouse buttons to be closer to original experience. Furthermore, only clicking mouse button 1 strokes the ball, other buttons in the mouse change the gamemode.
• Adds a custom cursor which also is closer to native experience. TBH, adding the cursor is kinda "hack" and does not improve the code. I will remove it if it is considered bad.
• Deobfuscates few variables and one method.
• Improves hacked shot rendering by drawing player ball instead of white rectangle at the end location.
• Adds documentation about controls to readme

Fixes #122

[PhilippvK]

@StenAL @pehala In case you want to have a look at this, too.

[pehala]

LGTM! Nice and short patch.

[nuhakala]

@PhilippvK Can this be merged?

[PhilippvK]

@PhilippvK Can this be merged?

While the code looks fine, I still would like to test your changes locally. I hope I will find time for this either today or tomorrow. Sorry for the delay.

[nuhakala]

No problem, take your time.

I have more coming once this is merged.

[StenAL]

I think the cursor color should be changed a bit to have more contrast with background blocks.

Here I have the new cursor in the middle of the screen and it's very hard to see:

Comparison with the previous cursor:

Everything else looks good to me.

[nuhakala]

Good point. I edited the cursor to have black cross inside a white cross, so now it should be visible anywhere. It does not look so original anymore, but at least is visible, since I don't know how to create dynamic contrast to it.

And my default cursor looked rather different to yours (if I had same as your I would have not created a custom one), I guess it depends on the cursors installed on the system. Using custom cursor at least makes it similar everywhere.

[PhilippvK]

I tested the patch and it seems to work (and look) fine!

@nuhakala would you mind adding a paragraph to the README which introduces the relevant keyboard/mouse controls?

[nuhakala]

Added documentation and updated the PR description to fix the related issue.

While I checked if I had missed some controls, I noticed that I had forgot to edit the hacked shot behavior. I removed also the keyboard controls from there, so that the shooting mode is controlled only through mouse.

And when checking that, I finally figured out how to use the hacked shot and tested it myself, was kinda fun :D Anyway, it was drawing only white rectangle to the target location, so I fixed that and now it draws the player ball there.

[PhilippvK]

@nuhakala Thanks!

There is a small listing-related issue in the CI. Fixing it should only take a minute (or less using mvn spotless:apply). After this is done, I am happy to merge it!

https://github.com/PhilippvK/playforia-minigolf/actions/runs/20236961663/job/58326018187#step:6:1

[nuhakala]

Applied now the spotless.