Skip to content

Conversation

@ened
Copy link
Contributor

@ened ened commented Apr 7, 2024

In preparation for #760, I wanted to extract the dependency upgrades & improvements needed.
This PR:

  • updates the lock files from running pub upgrade everywhere
  • removes gradle wrapper binaries, in line with how new flutter projects are created (flutter create -t app ..)
  • upgrades Android/detekt to reduce security warnings
  • upgrades Android/protobuf to reduce gradle warnings
  • minimally upgrades formatting to comply with detekt/ktlint configs
  • removes .ruby-version, a rbenv related file, as it is not relevant to the project (it's a detail on developer machines)

In order to get analyzer bumped to the latest version (and remove warnings etc), this PR needs to get merged in functional_data first & this project would then bump the dependency as needed.

@ened
Copy link
Contributor Author

ened commented Apr 8, 2024

@Taym95 appreciate a review if you have a minute :-)

@ened
Copy link
Contributor Author

ened commented Apr 8, 2024

I omitted a change log as no consumer-relevant changes are included this time, just build time/formatting improvements at most.

@ened
Copy link
Contributor Author

ened commented Apr 8, 2024

I omitted a change log as no consumer-relevant changes are included this time, just build time/formatting improvements at most.

The dart constraint update (to '>= 3.3.0', from '>=3.2.0-194.0.dev'), is technically a change but realistically yields the same version for consumers.

@ened
Copy link
Contributor Author

ened commented Apr 9, 2024

@Taym95 let me know if this needs further adjustments

@Taym95 Taym95 merged commit 96e083a into PhilipsHue:master Apr 10, 2024
@ened ened deleted the workspace-upgrade branch April 10, 2024 15:44
@ened
Copy link
Contributor Author

ened commented Apr 10, 2024

Thank you @Taym95 - soo much cleaner over in #760 :)

@Taym95 Taym95 mentioned this pull request Jan 3, 2025
rolandmosimann pushed a commit to BelimoAutomationAG/flutter_reactive_ble that referenced this pull request Jan 27, 2025
* Bump dependencies

* remove unused files

* add ios example gitignore

* upgrade a few test dependencies

* adjust workflow

* upgrade detekt.yml syntax

* update detekt config / minimal formatting adjustments

* re-run ios packaging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants