[Minor] Fix BarrelAnimData being loaded incorrectly #1809
Closed
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a unit's Section is present in the map file but lacks defined "BarrelTravel"/"BarrelCompressFrames"/"BarrelHoldFrames"/"BarrelRecoverFrames", the BarrelAnimData is incorrectly overwritten. This causes units such as [GTGCAN] to fail to render correctly after firing.
Coronia
approved these changes
Aug 14, 2025
|
这是来自QQ邮箱的假期自动回复邮件。你好，我最近正在休假中，无法亲自回复你的邮件。我将在假期结束后，尽快给你回复。
|
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
|
I think the fix in1625 has already solved this problem. You can copy it over as a separate fix. |
|
That's a nicer one, closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a unit's Section is present in the map file but lacks defined "BarrelTravel"/"BarrelCompressFrames"/"BarrelHoldFrames"/"BarrelRecoverFrames", the BarrelAnimData is incorrectly overwritten. This causes units such as [GTGCAN] to fail to render correctly after firing.