Skip to content

Add more data to the versioning file and convert it to json#103

Merged
crschardt merged 1 commit intoPhotonVision:mainfrom
samfreund:versioning
Nov 29, 2025
Merged

Add more data to the versioning file and convert it to json#103
crschardt merged 1 commit intoPhotonVision:mainfrom
samfreund:versioning

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Nov 29, 2025

Closes #90

@samfreund samfreund force-pushed the versioning branch 2 times, most recently from d077269 to 7b2016f Compare November 29, 2025 02:16
@samfreund samfreund requested a review from crschardt November 29, 2025 02:20

# Add photon version file
mkdir -p /opt/photonvision/
echo "${GITHUB_REF_NAME};${image_name}" > /opt/photonvision/image-version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we leave this here for compatibility with older versions of PhotonVision? If someone installs 2025.3.1 on a newer image, it won't find the version information. Deprecate it and we'll remove it in a future version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, I deprecated it for '27

Copy link
Contributor

@mcm001 mcm001 Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing 2025.3.1 on a newer image won't work for libcamera ABI compat, and I don't think we should be really supporting inter year flashing anyways?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing 2025.3.1 on a newer image won't work for libcamera ABI compat, and I don't think we should be really supporting inter year flashing anyways?

It doesn't hurt though, and it's a good idea to think about backwards-compat.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our images are still defaulting to 2025.3.1 because it's the latest release. Plus, libcamera is only a problem for RPi-based systems. Nothing stopping someone with an OPi from running 2025 on a newer image.

Copy link
Contributor

@crschardt crschardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does what it says

@crschardt crschardt merged commit 36a3f3c into PhotonVision:main Nov 29, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ImageVersion from dev

3 participants