Skip to content

Add OV9281 AE startup quirk #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add OV9281 AE startup quirk #1814

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d60771d
Add OV9281 AE startup quirk
mcm001 Mar 16, 2025
6f57d11
Update docs comment
mcm001 Mar 16, 2025
a0cf05b
oop
mcm001 Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...re/src/main/java/org/photonvision/vision/camera/USBCameras/GenericUSBCameraSettables.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,20 @@ public void setAutoWhiteBalance(boolean autoWB) {
}
}

@Override
public void setAutoExposure(boolean cameraAutoExposure) {
if (configuration.cameraQuirks.hasQuirk(CameraQuirk.ArduOV9281Controls)
&& !cameraAutoExposure) {
// OV9281 on Linux seems to sometimes ignore our exposure requests on first boot if we're in
// manual mode. Poking the camera into and out of auto exposure seems to fix it.
setAutoExposureImpl(true);
setAutoExposureImpl(false);
} else {
setAutoExposureImpl(cameraAutoExposure);
}
}

public void setAutoExposureImpl(boolean cameraAutoExposure) {
logger.debug("Setting auto exposure to " + cameraAutoExposure);

if (!cameraAutoExposure) {
Expand Down
Loading