-
Notifications
You must be signed in to change notification settings - Fork 244
Rip out legacy config provider #2067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I think you'll need to remove some of older network settings tests. May as well just go through and clean up all the old configs in test-resources as well. |
Likely, I just kinda ripped and touched the tests a little bit. I'll go through more thoroughly later when I have the chance. |
708bafa
to
d213616
Compare
Are we sure we don’t want to change the database schema or anything? I think Matt was interested removing the separate JSON columns in favor of unifying all of them into one. |
Like unifying all the various settings and config files? |
Let’s discuss that in an issue and come up with a plan for a different structure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcm001 What exactly does this test? I'm trying to figure out if I can just dump it since it covers the legacy config, and if dumping it means we need tests for the sql config too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should keep the Jackson tests iff the upgrade/migration they handle was added in 2025. Otherwise they don't need to stick around.
Do we want to resolve #1488 here as well? |
I would vote to keep the 1488 diff separate, just to make keeping track of commits once this is squashed more clear |
Description
We don't need this anymore for backwards compat, so we're getting rid of it! Less code, less clutter.
Meta
Merge checklist: