Skip to content

Conversation

@spacey-sooty
Copy link
Member

Description

Rn its just a design doc only PRing for feedback on that

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

Signed-off-by: Jade Turner <[email protected]>
@github-actions github-actions bot added the documentation Anything relating to https://docs.photonvision.org label Sep 23, 2025
Comment on lines +19 to +20
- How do we keep the coprocessor and robot code in sync?
- What do we do if the robot code and coprocessor have conflicting values?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My current plan for this is allow setting values on the coprocessor and always let the robot code override. The coprocessor can publish a value that says "I am going to be overriden" if it doesn't then a warning will show up in Photon Alerts saying your overriding coprocessor rejected tag IDs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap long lines pls. Sounds like a generally good plan? Not sold on the alert, might be better to have setting only in user code. Or the user has to publish a list to a NT topic and then it reads tags to exclude from there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From previous discussions we want to be able to control this with the coprocessor as a standalone unit meaning only setting in user code or through an NT topic isn't an option

Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
@github-actions github-actions bot added photonlib Things related to the PhotonVision library backend Things relating to photon-core and photon-server labels Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server documentation Anything relating to https://docs.photonvision.org photonlib Things related to the PhotonVision library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants