-
Couldn't load subscription status.
- Fork 261
Limit apriltag IDs (WIP) #2103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Limit apriltag IDs (WIP) #2103
Conversation
Signed-off-by: Jade Turner <[email protected]>
| - How do we keep the coprocessor and robot code in sync? | ||
| - What do we do if the robot code and coprocessor have conflicting values? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My current plan for this is allow setting values on the coprocessor and always let the robot code override. The coprocessor can publish a value that says "I am going to be overriden" if it doesn't then a warning will show up in Photon Alerts saying your overriding coprocessor rejected tag IDs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrap long lines pls. Sounds like a generally good plan? Not sold on the alert, might be better to have setting only in user code. Or the user has to publish a list to a NT topic and then it reads tags to exclude from there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From previous discussions we want to be able to control this with the coprocessor as a standalone unit meaning only setting in user code or through an NT topic isn't an option
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Description
Rn its just a design doc only PRing for feedback on that
Meta
Merge checklist: