-
Couldn't load subscription status.
- Fork 261
[NFC] Invert AprilTag family default #2124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'm not sure this PR actually changes our behacior, does it? |
It doesn't, it just makes it more clear what our default values are. Arguably it provides some optimization, but idt that's significant. This is more just a readability change, which imo is a good thing. |
photon-core/src/main/java/org/photonvision/vision/pipeline/AprilTagPipeline.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the tests pls
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
Signed-off-by: Jade Turner <[email protected]>
ec66f50 to
24821b6
Compare
Description
Switch default tag family used in AprilTag pipeline. We already functionally changed the default in #1333 but since 2024 FIRST appears to have been using 36h11 so switching here seems to make sense as well.
Meta
Merge checklist: