Merged
Conversation
samfreund
previously requested changes
Oct 17, 2025
Member
|
@mjansen4857 new version is cut over at https://github.com/photonvision/photon-image-modifier, if you want to bump that to |
Contributor
Author
|
Alright should be all set |
spacey-sooty
approved these changes
Oct 21, 2025
Member
spacey-sooty
left a comment
spacey-sooty
left a comment
There was a problem hiding this comment.
Do we want to add a hardware config? Otherwise looks reasonable
Contributor
Author
|
There's a hardware config in the database installed in the image modifier. |
spacey-sooty
pushed a commit
to spacey-sooty/photonvision
that referenced
this pull request
Dec 22, 2025
## Description Adds support for building images for the Luma P1. This bumps the image modifier pin to v2025.0.4. This pulls in: * Allow users to install any release via install.sh by @crschardt in PhotonVision/photon-image-modifier#49 * Exit install script if run on systemcore by @crschardt in PhotonVision/photon-image-modifier#58 * Fix --list-versions in install.sh by @crschardt in PhotonVision/photon-image-modifier#59 * Remove large folders of firmware that (probably) isn't needed by @crschardt in PhotonVision/photon-image-modifier#41 * Cancel in progress runs by @spacey-sooty in PhotonVision/photon-image-modifier#65 * Add limelight 4 support by @spacey-sooty in PhotonVision/photon-image-modifier#52 **Full Changelog**: PhotonVision/photon-image-modifier@v2025.0.3...v2025.0.4 ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for building images for the Luma P1. This bumps the image modifier pin to v2025.0.4. This pulls in:
Move compression outside of mount script (https://github.com/PhotonVision/photon-image-modifier/pull/84[)](https://github.com/PhotonVision/photon-image-modifier/commit/224a35cd3f714801402b73c389f5b00c5fd6e3c5)
Add Luma P1 support (https://github.com/PhotonVision/photon-image-modifier/pull/85[)](https://github.com/PhotonVision/photon-image-modifier/commit/cd928224b86600f5eb6fd2ff92ca88474c647815)
Fix tarball directory structure (https://github.com/PhotonVision/photon-image-modifier/pull/86[)](https://github.com/PhotonVision/photon-image-modifier/commit/970f1b585696d672a3f09d20d2c021fd924e577f)
Full Changelog: PhotonVision/photon-image-modifier@v2026.0.3...v2026.0.4
Meta
Merge checklist: