Lower AprilTagDetector's maxLineFitMSE #2138
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1817. Based on AprilRobotics/apriltag#375 (comment), I lowered it and light testing seems to indicate that this doesn't really impact range, but it does prevent cutoff tags from being detected. This value could be tuned lower to reduce bad detections even more, or higher to reduce false negatives, but this seems to be a good starting point.
Meta
Merge checklist: