Skip to content

Conversation

@Gold856
Copy link
Collaborator

@Gold856 Gold856 commented Oct 18, 2025

Description

Fixes #1817. Based on AprilRobotics/apriltag#375 (comment), I lowered it and light testing seems to indicate that this doesn't really impact range, but it does prevent cutoff tags from being detected. This value could be tuned lower to reduce bad detections even more, or higher to reduce false negatives, but this seems to be a good starting point.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner October 18, 2025 21:33
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Oct 18, 2025
Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment above is no longer true please change

@Gold856
Copy link
Collaborator Author

Gold856 commented Oct 19, 2025

Which comment? I edited the description to be slightly more specific just in case, but still unsure.

@spacey-sooty
Copy link
Member

Which comment? I edited the description to be slightly more specific just in case, but still unsure.

The WPILib 2025 defaults comment a few lines above your change. I can't leave a comment on it since you haven't modified it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Umich AprilTag Detector detects tags not fully in view; corners on edge of frame

2 participants