Skip to content

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Oct 23, 2025

Description

Instead of requiring users to click the snapshot button each time they want to grab an image, we now take snapshots whenever we have a target in the image. All of this is done in the frontend, so no backend changes are needed.

See here for an example.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner October 23, 2025 03:04
@github-actions github-actions bot added frontend Having to do with PhotonClient and its related items documentation Anything relating to https://docs.photonvision.org labels Oct 23, 2025
@mcm001
Copy link
Contributor

mcm001 commented Oct 23, 2025

I don't think there are any other places where the front end does significant thinking or state maintenance. Are we sure that pure front end is the right place for this feature to land?

@samfreund
Copy link
Member Author

I don't think there are any other places where the front end does significant thinking or state maintenance. Are we sure that pure front end is the right place for this feature to land?

I don't think we gain anything by implementing it in the backend, although I'll grant your point that it does add state maintenance. I chose to put it in the frontend because all it does is repeatedly send an image, which was previously something only the frontend can do. We could change it so that the backend requests the image, but that doesn't follow the previous implementation where the user sends the image from the frontend.

@samfreund samfreund force-pushed the fast-calib branch 2 times, most recently from 81003e1 to b5fb6f6 Compare October 23, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Anything relating to https://docs.photonvision.org frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants