Skip to content

Conversation

@TotalTaxAmount
Copy link

Description

This pr adds support for a couple Basler cameras that my team is using this year, namely the daA1280-54uc and [...]. It also depends on https://github.com/teamdeadbolts/basler_jni (I have just been using mavenLocal for development so not sure how that would work)

TODO:

  • Make everything work
  • Docs
  • ...

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@github-actions github-actions bot added frontend Having to do with PhotonClient and its related items backend Things relating to photon-core and photon-server labels Oct 23, 2025
@TotalTaxAmount
Copy link
Author

What do you guys want to do about this pr needed this added as a library https://github.com/teamdeadbolts/basler_jni? Right now I am just using mavenLocal which obviously won't work for merging this. I do have github action to publish it to github packages but that is kinda annoying because you need github credentials to even just download it.

@samfreund
Copy link
Member

What do you guys want to do about this pr needed this added as a library teamdeadbolts/basler_jni? Right now I am just using mavenLocal which obviously won't work for merging this. I do have github action to publish it to github packages but that is kinda annoying because you need github credentials to even just download it.

We should be able to pull that repo into PV and publish to our maven, if we're choosing to support the Basler cameras I'd like all the infra to be owned by us. @mcm001 Does that work for you?

I'm a little concerned about the support burden, as none of the developers have basler cameras, but if you're willing to take that on I think this is viable.

@TotalTaxAmount
Copy link
Author

Licenses are not compatible :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants