Skip to content

Conversation

@tqpcharlie
Copy link

Description

I added a warning to inform teams that the 8x8 chessboard can cause bad calibration results, and that the chArUco board should be used instead.

This is my first time contributing to this repo, so please let me know if there's anywhere else I should add this warning. 😄

This PR closes #1515.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@tqpcharlie tqpcharlie requested a review from a team as a code owner October 25, 2025 00:37
@github-actions github-actions bot added documentation Anything relating to https://docs.photonvision.org backend Things relating to photon-core and photon-server labels Oct 25, 2025
@github-actions github-actions bot removed the backend Things relating to photon-core and photon-server label Oct 25, 2025
@github-actions github-actions bot added the frontend Having to do with PhotonClient and its related items label Oct 25, 2025
@tqpcharlie tqpcharlie requested a review from samfreund October 25, 2025 04:03
Copy link
Member

@samfreund samfreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Nitpick: this PR has different capitalization for charuco than we typically use. If you want to go through and change capitalization everywhere else, feel free to do so. Otherwise, just change your capitalization to follow what we typically do.

Also, if you can run the linting, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Anything relating to https://docs.photonvision.org frontend Having to do with PhotonClient and its related items

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Strongly recommend charuco, and discourage chessboards

2 participants