-
Notifications
You must be signed in to change notification settings - Fork 283
Fix dimmable LED off-state, topic names, PWM flicker, and brightness update outside kDefault
#2337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix dimmable LED off-state, topic names, PWM flicker, and brightness update outside kDefault
#2337
Conversation
|
This works as expected on a LL2+ now, with additional image changes to enable hardware PWM (otherwise the brightness is flickery since PV doesn't leave room for consistent software PWM). |
frcwildfire8151
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can confirm this works, but Limelight 2+ still flickers when brightness isn't set to 0% or 100%.
frcwildfire8151
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried flashing Limelight 2 image and uploading this Limelight 2+ hardware config, it still flickers when brightness isn't set to 0% or 100%.
|
See my previous message for an explanation of why. |
|
Once combined with photon-image-modifier#124, this fixes all of the problems I identified with illumination LED control on a LL2+ |
|
Let's cut an image tag, and incorporate that in this PR? |
photon-core/src/main/java/org/photonvision/common/hardware/VisionLED.java
Outdated
Show resolved
Hide resolved
9f2131a to
c558585
Compare
c558585 to
0cb847e
Compare
photon-core/src/main/java/org/photonvision/common/hardware/VisionLED.java
Show resolved
Hide resolved
kDefault
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this code, but I'd like us to see how we can get any sort of test coverage of VisionLED.java in the future.
Description
This fixes a few problems with controlling dimmable LEDs.
kDefault. The output state is now tracked separately so that brightness updates can be correctly applied.Tested on a LL2+ and LL3, LED control works as expected (NT updates work, brightness changes work, brightness is not flickery) once combined with photon-image-modifier#124.
Closes #2335
Meta
Merge checklist: