Fix normalize tests and add multi-batch dimension test#623
Merged
Conversation
kvablack
requested review from
Michael-Equi,
jimmyt857 and
uzhilinsky
as code owners
- Fix test_normalize_update to properly handle vector batching - Fix test_serialize_deserialize to use multiple vectors - Add test_multiple_batch_dimensions to verify handling of complex batch shapes 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
kvablack
force-pushed
the
fix-normalize-tests
branch
from
65e60b5 to
6eb4446
Compare
ChenZhenY
pushed a commit
to ChenZhenY/openpi
that referenced
this pull request
Sep 23, 2025
…lligence#623) ## Summary - Fix test_normalize_update to properly handle vector batching in RunningStats - Fix test_serialize_deserialize to use multiple vectors (required by get_statistics) - Add test_multiple_batch_dimensions to verify handling of complex batch shapes like (2, 3, 4) ## Test plan - [x] All tests pass: `python -m pytest src/openpi/shared/normalize_test.py -v` - [x] Verified the new test covers multiple batch dimensions correctly 🤖 Generated with [Claude Code](https://claude.ai/code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
python -m pytest src/openpi/shared/normalize_test.py -v🤖 Generated with Claude Code