[DRAFT] Add Support for 1-Wire Protocol #435
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitch
approved these changes
Jan 6, 2025
Member
eitch
left a comment
eitch
left a comment
There was a problem hiding this comment.
This API looks quite well and sure should implement a basic 1-wire api to use. I have no objections, thanks @dariuszzbyrad
4 tasks
# Conflicts: # pi4j-core/src/main/java/com/pi4j/io/IOType.java # plugins/pi4j-plugin-linuxfs/src/main/java/com/pi4j/plugin/linuxfs/LinuxFsPlugin.java # plugins/pi4j-plugin-linuxfs/src/main/java/module-info.java
Member
|
@dariuszzbyrad I updated this branch to fix conflicts with the develop branch. What is the status from your point of view? Can we merge this now into V3? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a proposed API to support 1-Wire devices in the Pi4J library. The current state includes only the API definition, with implementation in the LinuxFS plugin and a mock version still pending.
New API
The API is available at the following location:
OneWireFileDataReaderWriterExample Usage
An example demonstrating how to use this API with DS18B20 and DS2413 devices can be found here:
OneWireTest.javaStatus
Next Steps
The PR is mostly complete, and I have tested it locally. However, merging it to the
developbranch and performing further testing will only be possible after the release of version 2.7.1. Once that release is finalized, the next version can be set to 3.0.0-SNAPSHOT, allowing this PR to move forward.@FDelporte @taartspi @eitch Feedback on the API design and usability is particularly welcome at this stage.