Fix Testing Tool for Camera 1 Still Image on Web App #164
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Camera 1 Still Image Test Tool did not return properly due to early timeout and unsuccessful return from lm_main due to segmentation fault caused by multiple calls to shutdown the ipc. Javascript to display and close the image display modal box after successful image capture also had a couple small errors preventing it from functioning properly.
What does this PR do?
Why is this change needed?
Allows user to successfully test that camera1 is working with the testing tools and to view the image from the web app after capture
Related Issue(s)
Changes Made
Testing Performed
Test Environment
Test Results
Camera1 Still Image Test successfully completes; Output logged to web and to log file; Camera1 Still Image Displayed in web app, and can successfully close modal dialog box.
Test Commands Run
N/A
Performance Impact
N/A
Breaking Changes
None
Dependencies
[ ] New dependencies added:
[ ] Updated dependencies:
Hardware Compatibility
Documentation
Screenshots/Videos
Checklist
Code Quality
Build & Test
./packaging/build.sh buildSubmission Requirements
git rebase -i HEAD~n)[PR TYPE] Brief descriptionAdditional Context