Skip to content

Conversation

@jeshernandez
Copy link
Collaborator

@jeshernandez jeshernandez commented Dec 9, 2025

Description

GSPro LM payload now sends valid LaunchMonitorBallDetected values.

What does this PR do?

  • Updates LaunchMonitorBallDetected initial to false.
  • Sends LaunchMonitorBallDetected when ball is found.
  • Sends LaunchMonitorBallDetected with false value when ball is being searched for.

Why is this change needed?

  • Enables OSG to display a ball is ready indicator without needing pitrac UI.
image

Related Issue(s)

Closes #

Changes Made

Testing Performed

Test Environment

  • Pi Model:
  • Camera Type:
  • OS Version:
  • Installation Method:

Test Results

  • pitrac test hardware passes
  • pitrac test camera passes (if camera-related)
  • pitrac test pulse passes (if strobe-related)
  • Simulator integration tested with:
  • Performance metrics:

Test Commands Run

# Paste the actual commands and output

Performance Impact

  • Before:
  • After:
  • Impact:

Breaking Changes

  • This PR includes breaking changes
    • What breaks:
    • Migration steps:

Dependencies

  • No new dependencies
  • [ ] New dependencies added:

  • [ ] Updated dependencies:

Hardware Compatibility

  • Tested on Pi 5
  • Tested on Pi 4
  • Tested with single Pi setup
  • Tested with dual Pi setup

Documentation

  • No documentation needed
  • Documentation updated in this PR
  • Documentation PR to follow
  • Updated relevant sections:
    • README
    • Hardware guide
    • Software guide
    • Troubleshooting guide

Screenshots/Videos

Checklist

Code Quality

  • Code follows existing patterns and conventions
  • No unnecessary comments added
  • Error handling implemented appropriately

Build & Test

  • Successfully builds with ./packaging/build.sh build
  • All existing tests pass
  • New tests added for new functionality
  • Tested on actual Raspberry Pi hardware (not just CI)

Submission Requirements

  • Commits squashed if needed (git rebase -i HEAD~n)
  • CLA signed
  • PR title follows format: [PR TYPE] Brief description
  • Branch is up-to-date with main

Additional Context


Copy link
Collaborator

@connorgallopo connorgallopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git history looks strange - but not gonna block you for that. I know you squash generally so nbd!

Good work - glad so see some work on this side of the project!

@jeshernandez
Copy link
Collaborator Author

Uh.. yea. Part of me rolling back merged changes to my forked project, and creating this PR at 1AM. Somewhere I also lost my GPG signature configuration. I actually tore the entire code apart in a private project, refactored the (C++ code side) directories to be in scope for their purpose (e.g. sim, core, etc.), renamed namespace, etc. I using another raspberry pi as a github action runner with all the required software pre-installed. Adding unit test, to start, etc. I am looking for improvements, speed gains, etc.

Copy link
Collaborator

@jamespilgrim jamespilgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jamespilgrim jamespilgrim merged commit cc2e7e2 into PiTracLM:main Dec 9, 2025
1 check passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants