-
-
Notifications
You must be signed in to change notification settings - Fork 50
Feature/gspro payload update heartbeat #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gspro payload update heartbeat #170
Conversation
connorgallopo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The git history looks strange - but not gonna block you for that. I know you squash generally so nbd!
Good work - glad so see some work on this side of the project!
|
Uh.. yea. Part of me rolling back merged changes to my forked project, and creating this PR at 1AM. Somewhere I also lost my GPG signature configuration. I actually tore the entire code apart in a private project, refactored the (C++ code side) directories to be in scope for their purpose (e.g. sim, core, etc.), renamed namespace, etc. I using another raspberry pi as a github action runner with all the required software pre-installed. Adding unit test, to start, etc. I am looking for improvements, speed gains, etc. |
jamespilgrim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Description
GSPro LM payload now sends valid LaunchMonitorBallDetected values.
What does this PR do?
Why is this change needed?
Related Issue(s)
Closes #
Changes Made
Testing Performed
Test Environment
Test Results
pitrac test hardwarepassespitrac test camerapasses (if camera-related)pitrac test pulsepasses (if strobe-related)Test Commands Run
# Paste the actual commands and outputPerformance Impact
Breaking Changes
Dependencies
[ ] New dependencies added:
[ ] Updated dependencies:
Hardware Compatibility
Documentation
Screenshots/Videos
Checklist
Code Quality
Build & Test
./packaging/build.sh buildSubmission Requirements
git rebase -i HEAD~n)[PR TYPE] Brief descriptionAdditional Context