small bugs

[asherikov]

Inconsistent cmake namespace: when building without ROS, the namespace is data_tamer:: instead of data_tamer_cpp::, in general all data_timer strings in https://github.com/PickNikRobotics/data_tamer/blob/main/data_tamer_cpp/CMakeLists.txt#L141 should be replaced with ${PROJECT_NAME}.

Package manifest lacks mcap build dependency -- liblz4-dev.

[asherikov]

Enforcing -Werror results in a failure in mcap when building with clang:

data_tamer_cpp/3rdparty/mcap/include/mcap/internal.hpp:72:28: error: implicit conversion loses integer precision: 'int' to 'uint16_t' (aka 'unsigned short') [-Werror,-Wimplicit-int-conversion]

return uint16_t(data[0]) | (uint16_t(data[1]) << 8);

[jlack1987]

I see the same thing, this is I guess technically an issue with the 3rd party mcap library though

[asherikov]

Yes, but the flag is set here https://github.com/PickNikRobotics/data_tamer/blob/main/data_tamer_cpp/CMakeLists.txt#L83